Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor src/idl_gen_cpp.cpp #7693

Merged
merged 6 commits into from Dec 6, 2022
Merged

Refactor src/idl_gen_cpp.cpp #7693

merged 6 commits into from Dec 6, 2022

Conversation

rishabhdeepsingh
Copy link
Contributor

  • Refactor to range based for loops for easy readability.
  • simplify some of the boolean expressions.
  • Refactor escaped string to Raw (R) string
    Thanks!

@github-actions github-actions bot added c++ codegen Involving generating code from schema labels Dec 4, 2022
enum-class
enum-class reviewed Dec 4, 2022
View reviewed changes
src/idl_gen_cpp.cpp Outdated Show resolved Hide resolved
enum-class
enum-class reviewed Dec 4, 2022
View reviewed changes
src/idl_gen_cpp.cpp Outdated Show resolved Hide resolved
enum-class
enum-class reviewed Dec 4, 2022
View reviewed changes
src/idl_gen_cpp.cpp Outdated Show resolved Hide resolved
@enum-class
Copy link
Contributor

Do you mind if refactor this too ?

@rishabhdeepsingh
Copy link
Contributor Author

@enum-class Done for the link as well

@dbaileychess dbaileychess enabled auto-merge (squash) December 6, 2022 00:38
@dbaileychess
Copy link
Collaborator

Thanks, always appreciate a cleanup PR!

@dbaileychess dbaileychess merged commit c0230d8 into google:master Dec 6, 2022
@rishabhdeepsingh
Copy link
Contributor Author

Thanks a lot for the quick review.

@rishabhdeepsingh rishabhdeepsingh deleted the refactor branch December 6, 2022 08:55
sunwen18 pushed a commit to sunwen18/flatbuffers that referenced this pull request Dec 25, 2022
@rishabhdeepsingh
Refactor src/idl_gen_cpp.cpp (google#7693)
3f57031 
* Refactor for loops and simplify code

* Refactor for loops and simplify code

* Fix for loop and reformat

* reformat code
candhyan pushed a commit to mediaz/flatbuffers that referenced this pull request Jan 2, 2023
@rishabhdeepsingh @candhyan
Refactor src/idl_gen_cpp.cpp (google#7693)
f5c533c 
* Refactor for loops and simplify code

* Refactor for loops and simplify code

* Fix for loop and reformat

* reformat code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enum-class enum-class enum-class left review comments

@dbaileychess dbaileychess dbaileychess approved these changes

Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rishabhdeepsingh @enum-class @dbaileychess