Remove --gen-name-strings flag from cmake command for generating union_vector_generated.h #7684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le-michael
changed the title
le-michael
changed the title
dbaileychess
approved these changes
Dec 1, 2022
|
It would be nice to unify the two at some point. I tried this in the past, but had issues forcing python on users. |
sunwen18
pushed a commit
to sunwen18/flatbuffers
that referenced
this pull request
Dec 25, 2022
…n_vector_generated.h (google#7684) * Sync make outputs with master * Remove --gen-name-string flag from CMAKE
candhyan
pushed a commit
to mediaz/flatbuffers
that referenced
this pull request
Jan 2, 2023
…n_vector_generated.h (google#7684) * Sync make outputs with master * Remove --gen-name-string flag from CMAKE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
cmake . && makeon a clean branch results in changes to tests/union_vector/union_vector_generated.h.The
generate_code.pyscript uses different flags than CMake when generating the C++ output for union_vector.fbs. This change should result incmake . && makeandgenerate_code.pygenerating the same output.