[C++] Update to address comparator failure in big endian #7681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elp resolve issue
dbaileychess
reviewed
Dec 1, 2022
enum-class
reviewed
Dec 2, 2022
sunwen18
changed the title
sunwen18
changed the title
enum-class
reviewed
Dec 4, 2022
enum-class
reviewed
Dec 4, 2022
added 2 commits
December 4, 2022 20:41
dbaileychess
reviewed
Dec 5, 2022
dbaileychess
previously approved these changes
Dec 6, 2022
dbaileychess
previously approved these changes
Dec 6, 2022
|
Thanks @sunwen18 Did you confirm that this fixes the issue on the Big Endian system? |
Yes, I followed the link you found and built a docker locally and then pull my fix and then run unit test, it can pass. |
dbaileychess
approved these changes
Dec 6, 2022
candhyan
pushed a commit
to mediaz/flatbuffers
that referenced
this pull request
Jan 2, 2023
* update unit test and generated file to test is extra endianswap can help resolve issue * remove EndianScalar wrapper from Get method * remove endianscalar wrapper * update * update * use Array instead * clang format * address error * clang * update * manually generate * Move Nim to completed language * Add swift link * address comments * update unit test * address comment * address comment * regenerate file * use auto instead of size_t * use uint32_t instead * update * format * delete extra whitespace Co-authored-by: Wen Sun <sunwen@google.com> Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #7685 of KeyCompareWithValue fail on big endian machines
The previous implementation compares an element from a array[index] and an element from Array.Get[index], the Get function performs and extra EndianSwap, thus the comparison is wrong.
Current implementation tested by running a docker image and pull the PR down and run. Following instructions here: https://til.simonwillison.net/docker/emulate-s390x-with-qemu