Fix java import wild card #7672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbaileychess could you help me with review this p.r. ? |
dbaileychess
previously approved these changes
Nov 28, 2022
dbaileychess
approved these changes
Nov 29, 2022
|
Thanks! |
sunwen18
pushed a commit
to sunwen18/flatbuffers
that referenced
this pull request
Dec 25, 2022
* Fix java import wild card * fix java include * Fix some import problems * clang-format * Sort imports Co-authored-by: Derek Bailey <derekbailey@google.com>
candhyan
pushed a commit
to mediaz/flatbuffers
that referenced
this pull request
Jan 2, 2023
* Fix java import wild card * fix java include * Fix some import problems * clang-format * Sort imports Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #7666 , we emit wildcard imports for java, which are generally a bad idea and can trigger linters. We should be explicit in what we include and need.