Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: arduino platform build #7625

Merged
merged 2 commits into from Nov 8, 2022
Merged

Fix: arduino platform build #7625

merged 2 commits into from Nov 8, 2022

Conversation

shuai132
Copy link
Contributor

@shuai132 shuai132 commented Nov 7, 2022

#if defined(ARDUINO) && !defined(ARDUINOSTL_M_H)

It will case comiple error(I'm using ESP32 and ESP8266 with Arduino SDK):

include/flatbuffers/base.h:36:12: fatal error: utility.h: No such file or directory

I have already read the issue: #4357 and I think it should only apply to AVR.

Because:

#include <utility>

this include is allowed on most platform(even mcu toolchains), e.g: esp32/esp8266/stm32. and arduino framework is works too.

@google-cla
Copy link

google-cla bot commented Nov 7, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the c++ label Nov 7, 2022
@dbaileychess dbaileychess merged commit 4de2814 into google:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants