[TS] Add support for fixed length arrays on Typescript (#5864) (#7021) #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
c++
codegen
bulentv
force-pushed
the
ts-support-for-fixed-length-arrays
branch
from
8ced3c0
to
643d5b2
Compare
github-actions
bot
added
c#
documentation
bulentv
force-pushed
the
ts-support-for-fixed-length-arrays
branch
from
643d5b2
to
ddd29d9
Compare
github-actions
bot
removed
rust
c#
documentation
bulentv
force-pushed
the
ts-support-for-fixed-length-arrays
branch
3 times, most recently
from
141d9a4
to
46e615c
Compare
bulentv
force-pushed
the
ts-support-for-fixed-length-arrays
branch
from
37f3058
to
4f93049
Compare
bulentv
force-pushed
the
ts-support-for-fixed-length-arrays
branch
4 times, most recently
from
646525f
to
c4d3d0d
Compare
…oogle#7021) * Typescript / Javascript don't have fixed arrays but it is important to support these languages for compatibility. * Generated TS code checks the length of the given array and do truncating / padding to conform to the schema. * Supports the both standard API and Object Based API. * Added a test. Co-authored-by: Mehmet Baker <mehmet.baker@zerodensity.tv> Signed-off-by: Bulent Vural <bulent.vural@zerodensity.tv> Signed-off-by: Bülent Vural <bulent.vural@zerodensity.tv>
bulentv
force-pushed
the
ts-support-for-fixed-length-arrays
branch
from
c4d3d0d
to
cda288f
Compare
|
@bjornharrtell Could you take a look |
|
@dbaileychess I think this generally looks good and is a welcome addition. |
bjornharrtell
previously approved these changes
Oct 28, 2022
Signed-off-by: Bülent Vural <bulent.vural@zerodensity.tv>
|
Added c716af8 to resolve review conversations. I left one open with a question to clarify. |
Signed-off-by: Bülent Vural <bulent.vural@zerodensity.tv>
Signed-off-by: Bülent Vural <bulent.vural@zerodensity.tv>
dbaileychess
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds full support for fixed length arrays to TS gen. Includes a test as well.