Rust fix compilation for no_std targets #2 #7553
Merged
+187
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperN
reviewed
Sep 27, 2022
|
Thanks! Generally LGTM with some nits |
|
Hello, can you pull again? #7518 had a lot of Rust changes |
This was referenced Oct 3, 2022
Merged
|
@CasperN Pulled and merged, still working and passing on my pc. |
|
@CasperN Build and CI seems to be passing, anything else we need to get this merged? |
CasperN
approved these changes
Oct 19, 2022
|
Good to merge. Are you able to push the button, or should I? |
I don't have access to that haha. |
bulentv
pushed a commit
to zdrealityhub/flatbuffers
that referenced
this pull request
Oct 21, 2022
* Fix nightly no_std * Fix nightly no_std
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my suggestion for a fix as suggested in #7338