Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit internal enums when swift_implementation_only #7545

Merged
merged 1 commit into from Sep 24, 2022
Merged

Emit internal enums when swift_implementation_only #7545

merged 1 commit into from Sep 24, 2022

Conversation

pauley-unsaturated
Copy link
Contributor

@pauley-unsaturated
Emit internal enums when swift_implementation_only
19aef99 
- Copy the same pattern as structs and tables
- Fixes google#7542
@github-actions github-actions bot added c++ codegen Involving generating code from schema swift labels Sep 23, 2022
@pauley-unsaturated
Copy link
Contributor Author

There: CLA Bot is much happier

mustiikhalil
mustiikhalil approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@mustiikhalil mustiikhalil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@pauley-unsaturated
Copy link
Contributor Author

Yay, thanks! Please merge when you're ready.

@mustiikhalil mustiikhalil merged commit cfe157e into google:master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustiikhalil mustiikhalil mustiikhalil approved these changes

Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swift source code generator outputs enum types as public with even with --swift-implementation-only flag
2 participants
@pauley-unsaturated @mustiikhalil