Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][FlexBuffers] throwing exception for untyped fixed vectors #7507

Merged
merged 2 commits into from Sep 2, 2022
Merged

[Java][FlexBuffers] throwing exception for untyped fixed vectors #7507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b5a567
[Java][FlexBuffers] throwing exception for untyped fixed vectors
paulovap Sep 1, 2022
a463f66
Merge branch 'master' into pp/java_exception_fixed_untyped_vector
dbaileychess Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion java/com/google/flatbuffers/FlexBuffersBuilder.java
View file
Open in desktop
Expand Up @@ -502,7 +502,9 @@ public ByteBuffer finish() {
* @return Value representing the created vector
*/
private Value createVector(int key, int start, int length, boolean typed, boolean fixed, Value keys) {
assert (!fixed || typed); // typed=false, fixed=true combination is not supported.
if (fixed & !typed)
throw new UnsupportedOperationException("Untyped fixed vector is not supported");

// Figure out smallest bit width we can store this vector with.
int bitWidth = Math.max(WIDTH_8, widthUInBits(length));
int prefixElems = 1;
Expand Down