Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove maven dependency of flatbuffers and use source folder #7503

Merged
merged 1 commit into from Sep 1, 2022
Merged

[Android] Remove maven dependency of flatbuffers and use source folder #7503

merged 1 commit into from Sep 1, 2022

Conversation

paulovap
Copy link
Collaborator

Fixes #7493

@dbaileychess
Copy link
Collaborator

Can you reenable the android build in BUILD.yml?

@github-actions github-actions bot added the CI Continuous Integration label Sep 1, 2022
@paulovap paulovap force-pushed the pp/fix_android_deps branch 4 times, most recently from c07b370 to dc9ee82 Compare September 1, 2022 20:21
@paulovap
Copy link
Collaborator Author

paulovap commented Sep 1, 2022 •
edited

@dbaileychess so, it is fine to move minSdkVersion to 26. This is just a sample app and has no effect on any library artifact that we publish to maven. Unfortunately, on Android, StandardCharsets only show on later APIs. When compile from source this object will be resolved against the Android's SDK.

@dbaileychess dbaileychess merged commit 7f75477 into google:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaileychess dbaileychess dbaileychess approved these changes

Assignees
No one assigned
Labels
c++ CI Continuous Integration kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flatbuffers Android App depends on fixed flatbuffer version
2 participants
@paulovap @dbaileychess