New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor src/idl_gen_cpp.cpp #7693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/idl_gen_cpp.cpp
enum-class
reviewed
Dec 4, 2022
enum-class
reviewed
Dec 4, 2022
enum-class
reviewed
Dec 4, 2022
Do you mind if refactor this too ? |
@enum-class Done for the link as well |
dbaileychess
approved these changes
Dec 6, 2022
Thanks, always appreciate a cleanup PR! |
Thanks a lot for the quick review. |
sunwen18
pushed a commit
to sunwen18/flatbuffers
that referenced
this pull request
Dec 25, 2022
* Refactor for loops and simplify code * Refactor for loops and simplify code * Fix for loop and reformat * reformat code
candhyan
pushed a commit
to mediaz/flatbuffers
that referenced
this pull request
Jan 2, 2023
* Refactor for loops and simplify code * Refactor for loops and simplify code * Fix for loop and reformat * reformat code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R
) stringThanks!