Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the logic of detecting at least one allowed usage more explicit. #4379

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link
Contributor

Make the logic of detecting at least one allowed usage more explicit.

The condition == UsageState.ALLOWED_USAGE doesn't convey the intention to trigger the finding for allowed usage only if at the same time there is no disallowed usage.
I'm renaming the constant to ONLY_ALLOWED_USAGE and adding the state transition methods to make the logic more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants