Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DiagnosticTestHelper and CompilationTestHelper to take java.util.function.Predicates #3905

Closed
wants to merge 0 commits into from
Closed

Update DiagnosticTestHelper and CompilationTestHelper to take java.util.function.Predicates #3905

wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link
Contributor

@copybara-service copybara-service bot commented May 11, 2023 •
edited

Update DiagnosticTestHelper and CompilationTestHelper to take java.util.function.Predicates

google/guava#6483 (comment)

Startblock:

  • unknown commit is submitted

@copybara-service copybara-service bot changed the title Add overloads that take java.util.function.Predicates Update DiagnosticTestHelper and CompilationTestHelper to take java.util.function.Predicates May 12, 2023
Stephan202
Stephan202 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Fast!

One thing to note: the Javadoc does still reference containsPattern (here and here), which might not be optimal once the method is deprecated.

@copybara-service copybara-service bot force-pushed the test_531307672 branch 4 times, most recently from a99142e to 74f1c13 Compare May 15, 2023 14:52
@copybara-service copybara-service bot closed this May 15, 2023
@copybara-service copybara-service bot deleted the test_531307672 branch May 15, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Stephan202