Improve UseCorrectAssertInTests handling for primitive equality comparisons #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…risons Recommended via[] assert a == 1; // usage to fix assertThat(a).isSameInstanceAs(1); // old transform assertThat(a).isEqualTo(1); // new behavior Performed a blaze_error_prone run on a sample directory to validate my own CUJ: unknown commit. I also started going down other related cleanups to tackle some other primitive comparison cases like "assert a == false" (to use isFalse) or "assert a > 0" (to use isGreaterThan), but there are so few usages that I don't think it's worth polishing and complicating this logic for such edge cases. PiperOrigin-RevId: 518647425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve UseCorrectAssertInTests handling for primitive equality comparisons
Recommended via[]
assert a == 1; // usage to fix
assertThat(a).isSameInstanceAs(1); // old transform
assertThat(a).isEqualTo(1); // new behavior
Performed a blaze_error_prone run on a sample directory to validate my own CUJ: unknown commit.
I also started going down other related cleanups to tackle some other primitive comparison cases like "assert a == false" (to use isFalse) or "assert a > 0" (to use isGreaterThan), but there are so few usages that I don't think it's worth polishing and complicating this logic for such edge cases.