Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend NullArgumentForNonNullParameter to match calls to some Immutable* methods and to ArgumentCaptor.forClass. #3680

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link
Contributor

Extend NullArgumentForNonNullParameter to match calls to some Immutable* methods and to ArgumentCaptor.forClass.

To match ArgumentCaptor.forClass, we have to start checking test-only code. But for now, we check such code only for calls to ArgumentCaptor.forClass.

(I suppose that we still don't handle the varargs parameters of the various Immutable* methods, since this entire check skips varargs, in part because varargs are confusing in general (b/232103314) and in part because we can't see annotations on a varargs-element type that is loaded from a .class file. We could make an exception for these methods if we really wanted, but I doubt it's worth it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants