Remove leading whitespace for UnusedVariable suggested fixes #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2500, at least for the UnusedVariable BugChecker
This PR now includes removing of up to one line of leading whitespace when suggesting a fix. This helps error-prone automated fixes look a bit more like how a developer may typically remove unused code, and avoids some of the extra unnecessary line breaks that a linter would not be able to remove.
Note to reviewers: I made sure to write the methods in such a way that behavior was only changed in places that were chosen deliberately, but please let me know if you'd prefer this to be behind a configuration option.