-
Notifications
You must be signed in to change notification settings - Fork 727
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add validation of parameters in
@BeforeTemplate
s and @AfterTemplate
s
Validate that all `@AfterTemplate` parameters are defined by the `@BeforeTemplate`s. Validation is performed during template compilation. Fixes #2257 COPYBARA_INTEGRATE_REVIEW=#2257 from PicnicSupermarket:rossendrijver/compile_time_binding_error 26e1c2d PiperOrigin-RevId: 370185469
- Loading branch information
Showing
3 changed files
with
72 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
...c/test/java/com/google/errorprone/refaster/testdata/template/KeyBindingErrorTemplate.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* | ||
* Copyright 2021 The Error Prone Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.errorprone.refaster.testdata.template; | ||
|
||
import com.google.errorprone.refaster.annotation.AfterTemplate; | ||
import com.google.errorprone.refaster.annotation.BeforeTemplate; | ||
|
||
/** | ||
* Refaster template which triggers an {@link IllegalArgumentException} upon compilation. | ||
* | ||
* <p>The {@code @AfterTemplate} defines parameters that are not present in all | ||
* {@code @BeforeTemplate} methods. | ||
*/ | ||
public class KeyBindingErrorTemplate { | ||
@BeforeTemplate | ||
public int before1(int a, int b) { | ||
return a + b; | ||
} | ||
|
||
@BeforeTemplate | ||
public int before2(int a, int c) { | ||
return a + c; | ||
} | ||
|
||
@AfterTemplate | ||
public int after(int a, int b, int c) { | ||
return a + b + c; | ||
} | ||
} |