Prepare RedundantSetterCall for becoming an ERROR.

PiperOrigin-RevId: 620003152
google · Mar 28, 2024 · 48ec7d9 · 48ec7d9
1 parent ed4b61d
commit 48ec7d9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/RedundantSetterCall.java b/core/src/main/java/com/google/errorprone/bugpatterns/RedundantSetterCall.java
@@ -19,7 +19,7 @@
 import static com.google.common.base.CaseFormat.UPPER_CAMEL;
 import static com.google.common.base.CaseFormat.UPPER_UNDERSCORE;
 import static com.google.common.collect.Streams.stream;
-import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;
+import static com.google.errorprone.BugPattern.SeverityLevel.ERROR;
 import static com.google.errorprone.VisitorState.memoize;
 import static com.google.errorprone.matchers.Matchers.allOf;
 import static com.google.errorprone.matchers.Matchers.anyOf;
@@ -66,7 +66,7 @@
 /** A BugPattern; see the summary. */
 @BugPattern(
     summary = "A field was set twice in the same chained expression.",
-    severity = WARNING,
+    severity = ERROR,
     altNames = "ProtoRedundantSet",
     tags = StandardTags.FRAGILE_CODE)
 public final class RedundantSetterCall extends BugChecker implements MethodInvocationTreeMatcher {

diff --git a/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java b/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java
@@ -794,6 +794,7 @@ public static ScannerSupplier warningChecks() {
           RandomCast.class,
           RandomModInteger.class,
           RectIntersectReturnValueIgnored.class,
+          RedundantSetterCall.class,
           RequiredModifiersChecker.class,
           RestrictedApiChecker.class,
           ReturnValueIgnored.class,
@@ -1032,7 +1033,6 @@ public static ScannerSupplier warningChecks() {
           ProtoTimestampGetSecondsGetNano.class,
           QualifierOrScopeOnInjectMethod.class,
           ReachabilityFenceUsage.class,
-          RedundantSetterCall.class,
           ReferenceEquality.class,
           RethrowReflectiveOperationExceptionAsLinkageError.class,
           ReturnAtTheEndOfVoidFunction.class,