Ban constructor injection on Kotlin inline value classes

RELNOTES=N/A PiperOrigin-RevId: 585117945
google · Nov 27, 2023 · 3f005e8 · 3f005e8
1 parent 0896fbe
commit 3f005e8
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/java/dagger/internal/codegen/validation/InjectValidator.java b/java/dagger/internal/codegen/validation/InjectValidator.java
@@ -255,6 +255,13 @@ private ValidationReport validateConstructor(XConstructorElement constructorElem
           constructorElement);
     }
 
+    if (enclosingElement.isValueClass()) {
+      builder.addError(
+          String.format("@%s constructors on Kotlin inline value classes is not supported",
+              injectAnnotation.simpleName()),
+              constructorElement);
+    }
+
     // Note: superficial validation of the annotations is done as part of getting the scopes.
     ImmutableSet<Scope> scopes =
         injectionAnnotations.getScopes(constructorElement.getEnclosingElement());

diff --git a/javatests/dagger/internal/codegen/InjectConstructorFactoryGeneratorTest.java b/javatests/dagger/internal/codegen/InjectConstructorFactoryGeneratorTest.java
@@ -147,6 +147,27 @@ public final class InjectConstructorFactoryGeneratorTest {
             });
   }
 
+  @Test public void injectConstructorOnInlineValueClass() {
+    Source file =
+        CompilerTests.kotlinSource(
+            "test.InlineValueClass.kt",
+            "package test",
+            "",
+            "import javax.inject.Inject;",
+            "",
+            "@JvmInline value class InlineValueClass",
+            "  @Inject constructor(private val v: Int)");
+    CompilerTests.daggerCompiler(file)
+        .compile(
+            subject -> {
+              subject.hasErrorCount(1);
+              subject.hasErrorContaining(
+                      "@Inject constructors on Kotlin inline value classes is not supported")
+                  .onSource(file)
+                  .onLine(6);
+            });
+  }
+
   @Test public void fieldAndMethodGenerics() {
     Source file =
         CompilerTests.javaSource(