Migrate to the new JavaPoetExtKt#toAnnotationSpec(XAnnotation) API …

…in XProcessing. RELNOTES=N/A PiperOrigin-RevId: 463664244
google · Jul 27, 2022 · 2cce0be · 2cce0be
1 parent 56335c1
commit 2cce0be
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/java/dagger/internal/codegen/writing/GwtCompatibility.java b/java/dagger/internal/codegen/writing/GwtCompatibility.java
@@ -18,6 +18,7 @@
 
 import static com.google.common.base.Preconditions.checkArgument;
 
+import androidx.room.compiler.processing.JavaPoetExtKt;
 import androidx.room.compiler.processing.XAnnotation;
 import androidx.room.compiler.processing.XElement;
 import com.squareup.javapoet.AnnotationSpec;
@@ -38,7 +39,7 @@ static Optional<AnnotationSpec> gwtIncompatibleAnnotation(Binding binding) {
       Optional<AnnotationSpec> gwtIncompatible =
           element.getAllAnnotations().stream()
               .filter(GwtCompatibility::isGwtIncompatible)
-              .map(XAnnotations::getAnnotationSpec)
+              .map(JavaPoetExtKt::toAnnotationSpec)
               .findFirst();
       if (gwtIncompatible.isPresent()) {
         return gwtIncompatible;

diff --git a/java/dagger/internal/codegen/writing/InjectionMethods.java b/java/dagger/internal/codegen/writing/InjectionMethods.java
@@ -52,6 +52,7 @@
 import static javax.lang.model.element.Modifier.PUBLIC;
 import static javax.lang.model.element.Modifier.STATIC;
 
+import androidx.room.compiler.processing.JavaPoetExtKt;
 import androidx.room.compiler.processing.XAnnotation;
 import androidx.room.compiler.processing.XConstructorElement;
 import androidx.room.compiler.processing.XExecutableElement;
@@ -78,7 +79,6 @@
 import dagger.internal.codegen.compileroption.CompilerOptions;
 import dagger.internal.codegen.extension.DaggerCollectors;
 import dagger.internal.codegen.javapoet.TypeNames;
-import dagger.internal.codegen.xprocessing.XAnnotations;
 import dagger.spi.model.DaggerAnnotation;
 import dagger.spi.model.DependencyRequest;
 import java.util.List;
@@ -434,7 +434,7 @@ private static MethodSpec fieldProxy(
                     .build())
             .addTypeVariables(typeVariableNames(enclosingType));
 
-    qualifier.map(XAnnotations::getAnnotationSpec).ifPresent(builder::addAnnotation);
+    qualifier.map(JavaPoetExtKt::toAnnotationSpec).ifPresent(builder::addAnnotation);
 
     boolean useObject = !isRawTypePubliclyAccessible(enclosingType.getType());
     UniqueNameSet parameterNameSet = new UniqueNameSet();

diff --git a/java/dagger/internal/codegen/xprocessing/XAnnotations.java b/java/dagger/internal/codegen/xprocessing/XAnnotations.java
@@ -21,19 +21,13 @@
 import androidx.room.compiler.processing.XAnnotation;
 import com.google.auto.common.AnnotationMirrors;
 import com.google.common.base.Equivalence;
-import com.squareup.javapoet.AnnotationSpec;
 import com.squareup.javapoet.ClassName;
 import java.util.Arrays;
 
 // TODO(bcorso): Consider moving these methods into XProcessing library.
 /** A utility class for {@link XAnnotation} helper methods. */
 public final class XAnnotations {
 
-  /** Returns the {@link AnnotationSpec} for the given annotation */
-  public static AnnotationSpec getAnnotationSpec(XAnnotation annotation) {
-    return AnnotationSpec.get(toJavac(annotation));
-  }
-
   /** Returns the string representation of the given annotation. */
   public static String toString(XAnnotation annotation) {
     return AnnotationMirrors.toString(toJavac(annotation));