Fix golang 1.11 compatibility on Windows #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.11beta1 introduces an incompatible change to the type of CertChainPolicyPara.ExtraPolicyPara field [1], which results in the following compile error on Windows: > x509\root_windows.go:112:3: cannot use > uintptr(unsafe.Pointer(sslPara)) (type uintptr) as type > syscall.Pointer in field value The fix, maintaining backward compatibility with Go 1.10 and 1.9, is to use type alias. Unfortunately it won't work with go < 1.9 as those earlier versions lack the type alias feature. This should fix issue google#284. [1] golang/go@4869ec00e87ef Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was referenced Jul 4, 2018
Closed
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
=======================================
Coverage 69.98% 69.98%
=======================================
Files 68 68
Lines 8769 8769
=======================================
Hits 6137 6137
Misses 2086 2086
Partials 546 546Continue to review full report at Codecov.
|
|
Alternative to this one: #286 |
|
Went for the #286 approach, let us know if we need to revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.11beta1 introduces an incompatible change to the type of
CertChainPolicyPara.ExtraPolicyPara field [1], which results
in the following compile error on Windows:
The fix, maintaining backward compatibility with Go 1.10 and 1.9,
is to use type alias. Unfortunately it won't work with go < 1.9
as those earlier versions lack the type alias feature.
This should fix issue #284.
[1] golang/go@4869ec00e87ef