Update the get_milliseconds test to match the spec #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jcking
reviewed
Sep 22, 2021
| @@ -325,7 +325,7 @@ section { | |||
| } | |||
| test { | |||
| name: "get_milliseconds" | |||
| description: "Need to import a variable to get milliseconds." | |||
| description: "Obtain the milliseconds component of the duration. Note, this is not the same as converting the duration to milliseconds. This behavior will be deprecated." | |||
| expr: "x.getMilliseconds()" | |||
| type_env { | |||
| name: "x" | |||
There was a problem hiding this comment.
Can you change the seconds: 123 below to seconds: 321? Took me a bit to realize this was only truncating the nanoseconds component to millis. Though to be fair as mentioned, this is not intuitive and will be removed at some point.
There was a problem hiding this comment.
No problem. Updated.
jcking
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #175
Bug also filed for google/cel-go#453 to address spec conformance.