Replace incomplete repository_os logic with get_host_triple #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
requested review from
dfreese,
UebelAndre,
illicitonion and
acmcarther
as code owners
dtolnay
commented
Apr 27, 2022
transitive_deps.bzl
Outdated
| @@ -6,4 +6,7 @@ load("@rules_rust//rust:repositories.bzl", "rust_repositories") | |||
| def cargo_raze_transitive_deps(): | |||
| """Loads all dependnecies from repositories required for cargo-raze""" | |||
| rules_foreign_cc_dependencies() | |||
| rust_repositories(include_rustc_srcs = True) | |||
| rust_repositories( | |||
| edition = "2018", | |||
There was a problem hiding this comment.
This change is needed due to bazelbuild/rules_rust#1256.
|
Sorry for the delay on this, but I think the issues with upstream rules_rust have been resolved with #506, so the main thrust of this change should not have a problem now. |
|
Rebased. |
dfreese
approved these changes
Jun 19, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazelbuild/rules_rust#1289 exposes a better way to figure out the right triple to use with
load_arbitrary_tool. In particular, we avoid assuming thatx86_64is always the correct architecture.