use containerd/containerd/api module #3526
Conversation
akhilerm
commented
May 4, 2024
•
akhilerm
commented
- use containerd/containerd/api module instead of having a copy in third_party
- use containerd/errdefs module instead of keeping a local copy
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
|
Hi @akhilerm. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Very exciting to see this happen! |
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
|
@bobbypage Can you approve the github action workflows also? |
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
|
/ok-to-test |
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
| @@ -60,7 +60,7 @@ function run_tests() { | |||
| --entrypoint="" \ | |||
| gcr.io/k8s-testimages/bootstrap \ | |||
| bash -c "export DEBIAN_FRONTEND=noninteractive && \ | |||
| echo 'deb http://deb.debian.org/debian buster-backports main'>/etc/apt/sources.list.d/buster.list && \ | |||
| echo 'deb http://archive.debian.org/debian buster-backports main'>/etc/apt/sources.list.d/buster.list && \ | |||
There was a problem hiding this comment.
This is being fixed in #3527 to switch to bookworm
|
/cc @bobbypage @dims for review |
| @@ -1,73 +1,74 @@ | |||
| module github.com/google/cadvisor | |||
|
|
|||
| go 1.19 | |||
| go 1.22.0 | |||
|
|
|||
| replace golang.org/x/net => golang.org/x/net v0.7.0 | |||
There was a problem hiding this comment.
@bobbypage Shouldnt this be removed? I am not sure why the version was pinned. Also v0.23.0 fixes CVE-2023-45288
|
/hold |
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
|
@akhilerm: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
