vendor: Rollback gopkg.in/yaml.v2 to v2.2.8 #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbypage
force-pushed
the
vendor-rollback-yaml
branch
from
6a0c326
to
f63546e
Compare
dashpole
approved these changes
Nov 12, 2020
|
can you link to where it was bumped in the first place? |
|
It's a transitive dependency of #2716 bumped In turn the bump of |
This was referenced Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch back to
gopkg.in/yaml.v2@v2.2.8gopkg.in/yaml.v2@v2.3.0has a breaking change that is affecting being able to vendor cadvisor into k/k ref kubernetes/kubernetes#96425 (comment) and go-yaml/yaml#670gopkg.in/yaml.v2@v2.3.0is a transitive dependency ofgithub.com/prometheus/common@v0.15.0. cadvisor moved togithub.com/prometheus/common@v0.15.0as part of #2716Downgrade dependent modules (e.g.
github.com/prometheus/common) for now to ensure we can stay ongopkg.in/yaml.v2@v2.2.8.