Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unicode Block features #86

Merged
merged 5 commits into from Nov 10, 2022
Merged

Remove Unicode Block features #86

merged 5 commits into from Nov 10, 2022

Conversation

tushuhei
Copy link
Member

@tushuhei tushuhei commented Nov 8, 2022 •
edited

This change is to remove Unicode block related features.

  • The accuracy is comparable with the previous models.
  • The entire file size gets smaller.
    • Model size
      • Japanese: 9.9 kB → 7.7kb
      • Simplified Chinese: 39 kB → 26kb
    • Bundle size
      • BudouX Japanese Web Component bundle: 17.2 kB → 12.3kb
      • BudouX Simplified Chinese Web Component bundle: 43.4 kB → 28.7kb
  • Faster processing
    • Parsing 1MB of text file: 5.805s → 3.099s

@tushuhei tushuhei merged commit ab7b522 into main Nov 10, 2022
@tushuhei tushuhei deleted the no-unicode-block branch December 14, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojiishi kojiishi Awaiting requested review from kojiishi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tushuhei