Change applyElement to call HTMLProcessor
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes `Parser.applyElement` to call the `HTMLProcessor` class. The `HTMLProcessorOptions.separator` is changed to accept a `Node`. This is because `undefined` had double meanings; i.e., use the default (ZWSP) and use the `<wbr>` element.
|
@tushuhei Please feel free to request changes or reject if this is not desirable as we discussed. This patch tries not to change the arguments and the separator of |
tushuhei
requested changes
May 10, 2022
javascript/src/parser.ts
Outdated
| } | ||
| }; | ||
| processChildren(parentElement); | ||
| const html_processor = new HTMLProcessor(this, { |
There was a problem hiding this comment.
nit. Let's rename this to htmlProcessor just for naming consistency :)
There was a problem hiding this comment.
Done, sorry I was using wrong styleguide ;-P
javascript/README.md
Outdated
|
|
||
| ```javascript | ||
| import { HTMLProcessor } from 'budoux'; | ||
| const ele = document.querySelector('p.budou-this'); | ||
| const applier = new HTMLProcessor(parser); | ||
| applier.applyToElement(ele); | ||
| const html_processor = new HTMLProcessor(parser, { |
tushuhei
approved these changes
May 12, 2022
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes
Parser.applyElementto call theHTMLProcessorclass.The
HTMLProcessorOptions.separatoris changed to accept aNode. This is becauseundefinedhad double meanings; i.e., use the default (ZWSP) and use the<wbr>element.