Regularize bindgen annotations. #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adetaylor
force-pushed
the
bindgen-annotation-macro
branch
from
37c5006
to
e6a5454
Compare
Previously autocxx_bindgen added annotations which were not valid Rust code. It now generates annotations which correspond to a real autocxx macro, and thus can more plausibly be upstreamed to the real bindgen. This also extracts a better encapsulated framework for parsing these attributes.
adetaylor
force-pushed
the
bindgen-annotation-macro
branch
from
1f7a4c3
to
b4f5a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously autocxx_bindgen added annotations which
were not valid Rust code.
It now generates annotations which correspond to a
real autocxx macro, and thus can more plausibly be
upstreamed to the real bindgen.
This also extracts a better encapsulated framework
for parsing these attributes.
Relates to #124.