Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spotless + ktlint to latest versions #496

Merged
merged 1 commit into from
May 25, 2021
Merged

Conversation

kevinmost
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Updates Spotless and ktlint, and re-runs ktlint.

ktlint had a bug that results in a cryptic error when attempting to use trailing commas (a valid Kotlin 1.4 feature). Updated ktlint to the latest version. Updated Spotless as well, and ran spotlessApply to apply the updated ktlint rules.

Type
Choose one: Code health

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@kevinmost kevinmost changed the title Udpate Spotless + ktlint to latest versions Update Spotless + ktlint to latest versions May 25, 2021
@kevinmost kevinmost marked this pull request as ready for review May 25, 2021 15:24
@kevinmost kevinmost enabled auto-merge (squash) May 25, 2021 15:24
@jingtang10
Copy link
Collaborator

thanks so much for this!

@kevinmost kevinmost merged commit 2d34748 into master May 25, 2021
@kevinmost kevinmost deleted the km/update-spotless branch May 25, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants