Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update terraform to use hash as comment per recommended guidelines #137

Merged
merged 3 commits into from Jan 16, 2023
Merged

update terraform to use hash as comment per recommended guidelines #137

merged 3 commits into from Jan 16, 2023

Conversation

verbanicm
Copy link
Contributor

Hashicorp documentation references using hash (#) as the default comment and is generally preferred to the long block comment style.

https://developer.hashicorp.com/terraform/language/syntax/configuration#comments

willnorris
willnorris requested changes Jan 15, 2023
View reviewed changes
Copy link
Collaborator

@willnorris willnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like a couple of unnecessary changes accidentally got included. Could you back those out? (or I can do it later when I have a little more time)

main_test.go Outdated Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
@verbanicm
Copy link
Contributor Author

Look like a couple of unnecessary changes accidentally got included. Could you back those out? (or I can do it later when I have a little more time)

Reverted those lines, auto formatter ftw!

@willnorris willnorris merged commit cfe103d into google:master Jan 16, 2023
@verbanicm verbanicm deleted the fix-tf branch January 16, 2023 20:33
@verbanicm
Copy link
Contributor Author

Thanks @willnorris !

flwyd pushed a commit to flwyd/addlicense that referenced this pull request Oct 27, 2023
@verbanicm @flwyd
update terraform to use hash as comment per recommended guidelines (g…
1216d4d 
…oogle#137)

* update terraform to use hash as comment per recommended guidelines (https://developer.hashicorp.com/terraform/language/syntax/configuration\#comments)

* update golanci-lint version in linter.yaml per PR google#132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willnorris willnorris willnorris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@verbanicm @willnorris