[Navigation Material] Fix Bottom Sheet Re-Appearing after Dismissal #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `show` calls are getting cancelled due to a race condition (https://issuetracker.google.com/issues/200980998) so we can't rely on their completion as a signal that the sheet is shown and we can mark the sheet's back stack entry's transition as complete. Using `withFrameNanos`, we try to wait until the sheet is visible. Test: Existing tests still pass (as they did despite the race condition...). Will try to create tests that fail before the fix. Manual testing apart from that. Fixes: google#725, google#720, google#700
jossiwolf
changed the title
ianhanniballake
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
What a hack. If it works, it works though.
If you can, I'd strongly suggest working on upstreaming a fix for this cancellation issue into Compose 1.1 (which we might be able to cherry pick to a Compose 1.0.X bug fix release) as I'd really prefer to remove these hacks and the need for ExperimentalCoroutinesApi here.
|
There's nothing I'd love more but I don't see where we could apply this to bottom sheet to improve :/ Trying to contribute another fix though and I'm hoping that that'll improve things! |
chrisbanes
approved these changes
Sep 30, 2021
|
Closing as this was merged as part of #742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
showcalls are getting cancelled due to a race condition (https://issuetracker.google.com/issues/200980998) so we can't rely on their completion as a signal that the sheet is shown and we can mark the sheet's back stack entry's transition as complete. I talked to Matvei and he suggested usingwithFrameNanoswhich works. It's more of a workaround/hack and I'd like to put a better solution in place soon, but this works for the time being.Test: Existing tests still pass (as they did despite the race condition...). Will try to create tests that fail before the fix. Manual testing apart from that.
Fixes: #725, #720, #700