Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pager] Re-write Pager on top of LazyRow|Column #678

Merged
merged 72 commits into from Sep 14, 2021
Merged

[Pager] Re-write Pager on top of LazyRow|Column #678

merged 72 commits into from Sep 14, 2021

Commits on Aug 19, 2021

  1. Experimenting with changing Pager to use LazyRow

    @chrisbanes
    chrisbanes committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    0fd2416 View commit details
    Browse the repository at this point in the history

  2. Attempt to migrate some state over

    @chrisbanes
    chrisbanes committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    bd38e05 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Add support for center/start/end alignment

    @chrisbanes
    chrisbanes committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    b29d5d0 View commit details
    Browse the repository at this point in the history

  2. Layout page + offsets calculations are working

    @chrisbanes
    chrisbanes committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    0fea85a View commit details
    Browse the repository at this point in the history

  3. Vaguely working scrolls/flings

    @chrisbanes
    chrisbanes committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    1d0392b View commit details
    Browse the repository at this point in the history

  4. Try generalising the snapping fling

    @chrisbanes
    chrisbanes committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    d1e5f99 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Allow snapOffset to be configurable

    @chrisbanes
    chrisbanes committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    ee4e6b6 View commit details
    Browse the repository at this point in the history

  2. Extract snapping fling behavior

    @chrisbanes
    chrisbanes committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    131f907 View commit details
    Browse the repository at this point in the history

  3. Add broken spring animation

    @chrisbanes
    chrisbanes committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    0dc2aa3 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Working snapping fling

    @chrisbanes
    chrisbanes committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    1ba6721 View commit details
    Browse the repository at this point in the history

  2. Provide LazyItemScope to Pager content

    @chrisbanes
    chrisbanes committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    e4c7489 View commit details
    Browse the repository at this point in the history

  3. First attempt at getting the tests to pass

    @chrisbanes
    chrisbanes committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    bfe7a08 View commit details
    Browse the repository at this point in the history

  4. Update state after an animation

    @chrisbanes
    chrisbanes committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    39b39ad View commit details
    Browse the repository at this point in the history

  5. Re-enable Robolectric Pager tests

    @chrisbanes
    chrisbanes committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    42077ea View commit details
    Browse the repository at this point in the history

  6. Lots of fixes

    @chrisbanes
    chrisbanes committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    b2fddcd View commit details
    Browse the repository at this point in the history

  7. Add reverseLayout support

    @chrisbanes
    chrisbanes committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    cdf4972 View commit details
    Browse the repository at this point in the history

  8. Fixing some more tests

    @chrisbanes
    chrisbanes committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    18514ec View commit details
    Browse the repository at this point in the history

  9. Remove inifite looping

    @chrisbanes
    chrisbanes committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    889f4d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Use fillParentMax* in samples

    @chrisbanes
    chrisbanes committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    245ddce View commit details
    Browse the repository at this point in the history

  2. Move away from using contentPadding 

    Due to https://issuetracker.google.com/issues/197727780
    @chrisbanes
    chrisbanes committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    0baf50c View commit details
    Browse the repository at this point in the history

  3. Tidy up paging offsets

    @chrisbanes
    chrisbanes committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    fe77a9f View commit details
    Browse the repository at this point in the history

  4. Finally all tests are passing!

    @chrisbanes
    chrisbanes committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    07b6c16 View commit details
    Browse the repository at this point in the history

  5. Fix scrollToPage

    @chrisbanes
    chrisbanes committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    829181e View commit details
    Browse the repository at this point in the history

  6. Add a semi-working animateScrollToPage

    @chrisbanes
    chrisbanes committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    6da48a4 View commit details
    Browse the repository at this point in the history

  7. Update API files

    @chrisbanes
    chrisbanes committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    2a2a043 View commit details
    Browse the repository at this point in the history

  8. Remove dragEnabled parameter

    @chrisbanes
    chrisbanes committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    dec9f87 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Fix nested scrolls getting to Pager

    @chrisbanes
    chrisbanes committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    758d97f View commit details
    Browse the repository at this point in the history

  2. Fix device tests

    @chrisbanes
    chrisbanes committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    f64263f View commit details
    Browse the repository at this point in the history

  3. Add scrollOffset back to scrollToPage

    @chrisbanes
    chrisbanes committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    bd7df36 View commit details
    Browse the repository at this point in the history

  4. Expose key parameter

    @chrisbanes
    chrisbanes committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    f8bd852 View commit details
    Browse the repository at this point in the history

  5. Expose contentPadding parameter

    @chrisbanes
    chrisbanes committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    ee606ab View commit details
    Browse the repository at this point in the history

  6. Update docs

    @chrisbanes
    chrisbanes committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    2cbe157 View commit details
    Browse the repository at this point in the history

  7. More tidy-ups

    @chrisbanes
    chrisbanes committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    01f4892 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Remove LazyItemScope from PagerScope

    @chrisbanes
    chrisbanes committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    56a202c View commit details
    Browse the repository at this point in the history

  2. Add comment for use of ConsumeFlingNestedScrollConnection

    @chrisbanes
    chrisbanes committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    2671e61 View commit details
    Browse the repository at this point in the history

  3. Tweak comment

    @chrisbanes
    chrisbanes committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    7ffcf33 View commit details
    Browse the repository at this point in the history

  4. Add comment about usage of BoxWithConstraints

    @chrisbanes
    chrisbanes committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    ee2ec3a View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary call to onScrollFinished()

    @chrisbanes
    chrisbanes committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    1d22c48 View commit details
    Browse the repository at this point in the history

  6. Move count parameter 

    It has now moved to the Pager functions, rather
than on PagerState. This closer matches how Lazy*
works.
    @chrisbanes
    chrisbanes committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    d9ff81e View commit details
    Browse the repository at this point in the history

  7. Fix HorizontalPager

    @chrisbanes
    chrisbanes committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    d4ec005 View commit details
    Browse the repository at this point in the history

  8. Play around with using contentPadding to provide alignment 

    Not working yet
    @chrisbanes
    chrisbanes committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    56f2f18 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. Fix snapping point

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    54c2c6d View commit details
    Browse the repository at this point in the history

  2. Update horizontal layout assertion

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    6a16814 View commit details
    Browse the repository at this point in the history

  3. Update to Compose SNAPSHOT 7655479

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    758ce3c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'cb/snapshot-7655479' into cb/pager-lazy-contentpadding

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    19a97f6 View commit details
    Browse the repository at this point in the history

  5. Fix scrollToPage test

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    b6dc4ed View commit details
    Browse the repository at this point in the history

  6. Fix snapOffset used in page offset calculation

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    7a79250 View commit details
    Browse the repository at this point in the history

  7. Fix calculateHorizontalPadding()

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    9474dcb View commit details
    Browse the repository at this point in the history

  8. Fix swipeToEndAndBack test

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    e10bf32 View commit details
    Browse the repository at this point in the history

  9. Update Pager samples

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    0870e3f View commit details
    Browse the repository at this point in the history

  10. Fix derivedStates reading themselves

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    bf297b2 View commit details
    Browse the repository at this point in the history

  11. Run spotless on tests

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    cf39c70 View commit details
    Browse the repository at this point in the history

  12. Some vertical test fixes

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    1867739 View commit details
    Browse the repository at this point in the history

  13. Remove BoxWithConstraints

    @chrisbanes
    chrisbanes committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    a6a2618 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Merge branch 'main' into cb/pager-lazy

    @chrisbanes
    chrisbanes committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    da9f75f View commit details
    Browse the repository at this point in the history

  2. Update vertical pager samples

    @chrisbanes
    chrisbanes committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    f5ee829 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Most tests are now passing!

    @chrisbanes
    chrisbanes committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    fc4ad3e View commit details
    Browse the repository at this point in the history

  2. Update API files

    @chrisbanes
    chrisbanes committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    9fd2489 View commit details
    Browse the repository at this point in the history

  3. Fix compile error

    @chrisbanes
    chrisbanes committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    2a13c50 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Merge branch 'main' into cb/pager-lazy

    @chrisbanes
    chrisbanes committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    91872dc View commit details
    Browse the repository at this point in the history

  2. Add some clarifying comments

    @chrisbanes
    chrisbanes committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    3764dd8 View commit details
    Browse the repository at this point in the history

  3. Update our scrolling tests to use Dp based velocities 

    This makes our tests less-flakey since they should act the
same across different screen densities.
    @chrisbanes
    chrisbanes committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    62c2574 View commit details
    Browse the repository at this point in the history

  4. Hide SnappingFligBehavior for now

    @chrisbanes
    chrisbanes committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    ce8a6c6 View commit details
    Browse the repository at this point in the history

  5. Add rememberPagerFlingConfig back (deprecated)

    @chrisbanes
    chrisbanes committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    a2bf597 View commit details
    Browse the repository at this point in the history

  6. Add looping sample

    @chrisbanes
    chrisbanes committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    6d8e8ea View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. Update docs and guide

    @chrisbanes
    chrisbanes committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    76dfecc View commit details
    Browse the repository at this point in the history

  2. Remove unused code

    @chrisbanes
    chrisbanes committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    d5a6e61 View commit details
    Browse the repository at this point in the history

  3. Add some deprecated functions back in

    @chrisbanes
    chrisbanes committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    1e9ddfb View commit details
    Browse the repository at this point in the history

  4. Add pageOffset back to animateScrollToPage

    @chrisbanes
    chrisbanes committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    4e45979 View commit details
    Browse the repository at this point in the history

  5. List more doc differences

    @chrisbanes
    chrisbanes committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    355d14e View commit details
    Browse the repository at this point in the history

  6. Update requireCurrentPage

    @chrisbanes
    chrisbanes committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    290d83a View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Merge branch 'main' into cb/pager-lazy

    @chrisbanes
    chrisbanes committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    f7f0052 View commit details
    Browse the repository at this point in the history