Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[DrawablePainter] Fix overwriting bounds of drawable when drawing it via DrawablePainter" #1368

Merged
merged 1 commit into from Oct 12, 2022
Merged

Revert "[DrawablePainter] Fix overwriting bounds of drawable when drawing it via DrawablePainter" #1368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 0 additions & 26 deletions drawablepainter/build.gradle
View file
Open in desktop
Expand Up @@ -66,32 +66,6 @@ android {
dependencies {
implementation libs.compose.ui.ui
implementation libs.kotlin.coroutines.android

// ======================
// Test dependencies
// ======================

androidTestImplementation libs.compose.foundation.foundation

androidTestImplementation project(':internal-testutils')
testImplementation project(':internal-testutils')

androidTestImplementation libs.junit
testImplementation libs.junit

androidTestImplementation libs.truth
testImplementation libs.truth

androidTestImplementation libs.compose.ui.test.junit4
testImplementation libs.compose.ui.test.junit4

androidTestImplementation libs.compose.ui.test.manifest
testImplementation libs.compose.ui.test.manifest

androidTestImplementation libs.androidx.test.runner
testImplementation libs.androidx.test.runner

testImplementation libs.robolectric
}

apply plugin: "com.vanniktech.maven.publish"
88 changes: 0 additions & 88 deletions ...nter/src/androidTest/kotlin/com/google/accompanist/drawablepainter/DrawablePainterTest.kt
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions drawablepainter/src/androidTest/kotlin/com/google/accompanist/drawablepainter/Drawables.kt
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions drawablepainter/src/main/java/com/google/accompanist/drawablepainter/DrawablePainter.kt
View file
Open in desktop
Expand Up @@ -130,10 +130,8 @@ class DrawablePainter(
// Reading this ensures that we invalidate when invalidateDrawable() is called
drawInvalidateTick

// Update the Drawable's bounds if necessary
if (drawable.bounds.isEmpty) {
drawable.setBounds(0, 0, size.width.roundToInt(), size.height.roundToInt())
}
// Update the Drawable's bounds
drawable.setBounds(0, 0, size.width.roundToInt(), size.height.roundToInt())

canvas.withSave {
drawable.draw(canvas.nativeCanvas)
Expand Down