Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pager] Fix Modifier.pagerTabIndicatorOffset() #1194

Merged
merged 3 commits into from Jun 10, 2022
Merged

[Pager] Fix Modifier.pagerTabIndicatorOffset() #1194

merged 3 commits into from Jun 10, 2022

Commits on Jun 9, 2022

  1. [Pager] Fix Modifier.pagerTabIndicatorOffset() 

    After pagerState.currentPage was changed to be updated once we scrolled half of the page the indicator offsets were broken.
I also removed unneeded use of composed modifier and page scrolls causing recomposition.
    @andkulikov
    andkulikov committed Jun 9, 2022
    Copy the full SHA
    9cd006b View commit details
    Browse the repository at this point in the history

  2. [Pager] Fix Modifier.pagerTabIndicatorOffset() 

    After pagerState.currentPage was changed to be updated once we scrolled half of the page the indicator offsets were broken.
I also removed unneeded use of composed modifier and page scrolls causing recomposition.
    @andkulikov
    andkulikov committed Jun 9, 2022
    Copy the full SHA
    fe2ca3c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' 

    # Conflicts:
#	pager-indicators/src/androidTest/kotlin/com/google/accompanist/pager/TabIndicatorTest.kt
    @andkulikov
    andkulikov committed Jun 9, 2022
    Copy the full SHA
    92b142e View commit details
    Browse the repository at this point in the history