[Navigation Material] Update Docs and Sample to use new API for adding custom Navigators #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Navigation 2.4.0-alpha10 is out now so I think you can update the dependency now. |
|
Will do, thanks for the heads up! The snapshot was failing to resolve a dependency |
jossiwolf
changed the title
jossiwolf
force-pushed
the
navigation-material-custom-navigators-api
branch
from
59325c2
to
fb58bfe
Compare
jossiwolf
force-pushed
the
navigation-material-custom-navigators-api
branch
from
fb58bfe
to
520d2ad
Compare
|
The one test that failed was a Pager test, there shouldn't be any connection. |
ianhanniballake
requested changes
Sep 30, 2021
| if (savedState != null) navController.restoreState(savedState) | ||
| navigator = remember(navController) { BottomSheetNavigator(sheetState) } | ||
| navController.navigatorProvider += navigator |
There was a problem hiding this comment.
You don't need this line anymore
chrisbanes
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged once Nav 2.4.0 Alpha 10 is released :)
Fixes #744