Update Docs and Sample to use new API for adding custom Navigators

Fixes #744
google · Sep 29, 2021 · 59325c2 · 59325c2
1 parent 6611ebd
commit 59325c2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 12 deletions.
diff --git a/docs/navigation-material.md b/docs/navigation-material.md
@@ -18,9 +18,8 @@ This features composable bottom sheet destinations.
     ```kotlin
     @Composable
     fun MyApp() {
-        val navController = rememberNavController()
         val bottomSheetNavigator = rememberBottomSheetNavigator()
-        navController.navigatorProvider += bottomSheetNavigator
+        val navController = rememberNavController(bottomSheetNavigator)
     }
     ```
 
@@ -29,9 +28,8 @@ This features composable bottom sheet destinations.
     ```kotlin
     @Composable
     fun MyApp() {
-        val navController = rememberNavController()
         val bottomSheetNavigator = rememberBottomSheetNavigator()
-        navController.navigatorProvider += bottomSheetNavigator
+        val navController = rememberNavController(bottomSheetNavigator)
         ModalBottomSheetLayout(bottomSheetNavigator) {
             NavHost(navController, Destinations.Home) {
                // We'll define our graph here in a bit!
@@ -45,9 +43,8 @@ This features composable bottom sheet destinations.
     ```kotlin
     @Composable
     fun MyApp() {
-        val navController = rememberNavController()
         val bottomSheetNavigator = rememberBottomSheetNavigator()
-        navController.navigatorProvider += bottomSheetNavigator
+        val navController = rememberNavController(bottomSheetNavigator)
         ModalBottomSheetLayout(bottomSheetNavigator) {
             NavHost(navController, Destinations.Home) {
                composable(route = "home") {

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -1,6 +1,6 @@
 [versions]
 compose = "1.0.2"
-composesnapshot = "-" # a single character = no snapshot
+composesnapshot = "7778007" # a single character = no snapshot
 
 # gradlePlugin and lint need to be updated together
 gradlePlugin = "7.0.2"
@@ -13,7 +13,7 @@ okhttp = "3.12.13"
 coil = "1.3.0"
 
 androidxtest = "1.4.0"
-androidxnavigation = "2.4.0-alpha09"
+androidxnavigation = "2.4.0-SNAPSHOT"
 
 [libraries]
 compose-ui-ui = { module = "androidx.compose.ui:ui", version.ref = "compose" }

diff --git a/...c/androidTest/java/com/google/accompanist/navigation.material/BottomSheetNavigatorTest.kt b/...c/androidTest/java/com/google/accompanist/navigation.material/BottomSheetNavigatorTest.kt
@@ -198,9 +198,9 @@ internal class BottomSheetNavigatorTest {
         val sheetState = ModalBottomSheetState(ModalBottomSheetValue.Hidden)
 
         composeTestRule.setContent {
-            navController = rememberNavController()
+            navigator = remember { BottomSheetNavigator(sheetState) }
+            navController = rememberNavController(navigator)
             if (savedState != null) navController.restoreState(savedState)
-            navigator = remember(navController) { BottomSheetNavigator(sheetState) }
             navController.navigatorProvider += navigator
             if (compositionState == 0) {
                 ModalBottomSheetLayout(

diff --git a/...e/src/main/java/com/google/accompanist/sample/navigation/material/BottomSheetNavSample.kt b/...e/src/main/java/com/google/accompanist/sample/navigation/material/BottomSheetNavSample.kt
@@ -58,9 +58,8 @@ private object Destinations {
 @OptIn(ExperimentalMaterialNavigationApi::class)
 @Composable
 fun BottomSheetNavDemo() {
-    val navController = rememberNavController()
     val bottomSheetNavigator = rememberBottomSheetNavigator()
-    navController.navigatorProvider += bottomSheetNavigator
+    val navController = rememberNavController(bottomSheetNavigator)
 
     ModalBottomSheetLayout(bottomSheetNavigator) {
         NavHost(navController, Destinations.Home) {