[Navigation Material] Fix Bottom Sheet Fully Expanding #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `show` calls are getting cancelled due to a race condition (https://issuetracker.google.com/issues/200980998) so we can't rely on their completion as a signal that the sheet is shown and we can mark the sheet's back stack entry's transition as complete. Using `withFrameNanos`, we try to wait until the sheet is visible. Test: Existing tests still pass (as they did despite the race condition...). Will try to create tests that fail before the fix. Manual testing apart from that. Fixes: google#725, google#720, google#700
hrach
reviewed
Sep 28, 2021
...gation-material/src/main/java/com/google/accompanist/navigation/material/SheetContentHost.kt
Outdated
Show resolved
Hide resolved
Calling `show` too early means that the SwipeableState's anchors won't have been properly calculated yet so we wait for a few frames. Test: SheetContentHostTest#testSheetHalfExpanded_onBackStackEntryEnter_shortSheet, SheetContentHostTest#testSheetHalfExpanded_onBackStackEntryEnter_tallSheet Fixes: google#717
jossiwolf
force-pushed
the
sheet-fully-expands
branch
from
c649b83
to
2eb346e
Compare
chrisbanes
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda similar to #741 - we were calling
showtoo early. That meant that theSwipeableState/ModalBottomSheetState'sanchorswouldn't have been calculated properly yet. By default, a sheet will have two anchors:HiddenandExpanded. IfsheetHeight > containerHeight / 2, the sheet should have aHalfExpandedstate. For that,ModalBottomSheetLayoutneeds to know the sheet's height, making it two-pass. The effect we use toshowthe sheet got called on the first pass though, when the sheet content is composed to measure it, but the anchors didn't have the correct sheet height yet, causing the sheet to fully expand despite it being tall enough to have aHalfExpandedstate.This isn't a nice solution but in agreement with Matvei, it seems to be the most reasonable fix for the moment.