Move mock web server delay default to function

google · Oct 15, 2020 · aac5532 · aac5532
1 parent f253b23
commit aac5532
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 11 deletions.
diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml
diff --git a/coil/src/androidTest/java/dev/chrisbanes/accompanist/coil/CoilTest.kt b/coil/src/androidTest/java/dev/chrisbanes/accompanist/coil/CoilTest.kt
@@ -77,7 +77,7 @@ class CoilTest {
     val composeTestRule = createComposeRule()
 
     // Our MockWebServer. We use a response delay to simulate real-world conditions
-    private val server = ImageMockWebServer(responseDelayMs = 200)
+    private val server = ImageMockWebServer()
 
     @Before
     fun setup() {

diff --git a/glide/src/androidTest/java/dev/chrisbanes/accompanist/glide/GlideTest.kt b/glide/src/androidTest/java/dev/chrisbanes/accompanist/glide/GlideTest.kt
@@ -73,7 +73,7 @@ class GlideTest {
     val composeTestRule = createComposeRule()
 
     // Our MockWebServer. We use a response delay to simulate real-world conditions
-    private val server = ImageMockWebServer(responseDelayMs = 200)
+    private val server = ImageMockWebServer()
 
     @Before
     fun setup() {

diff --git a/...estutils/src/main/java/dev/chrisbanes/accompanist/imageloading/test/ImageMockWebServer.kt b/...estutils/src/main/java/dev/chrisbanes/accompanist/imageloading/test/ImageMockWebServer.kt
@@ -26,10 +26,13 @@ import okio.Buffer
 import java.util.concurrent.TimeUnit
 
 /**
- * [MockWebServer] which returns a valid response at the path `/image`, and a 404 for anything else.
- * We add a small delay to simulate 'real-world' network conditions.
+ * A [MockWebServer] which returns a valid image responses at various paths, and a 404
+ * for anything else.
+ *
+ * @param responseDelayMs Allows the setting of a response delay to simulate 'real-world'
+ * network conditions. Defaults to 200ms.
  */
-fun ImageMockWebServer(responseDelayMs: Long = 0): MockWebServer {
+fun ImageMockWebServer(responseDelayMs: Long = 200): MockWebServer {
     val dispatcher = object : Dispatcher() {
         override fun dispatch(request: RecordedRequest): MockResponse = when (request.path) {
             "/image" -> {

diff --git a/picasso/src/androidTest/java/dev/chrisbanes/accompanist/picasso/PicassoTest.kt b/picasso/src/androidTest/java/dev/chrisbanes/accompanist/picasso/PicassoTest.kt
@@ -68,7 +68,7 @@ class PicassoTest {
     val composeTestRule = createComposeRule()
 
     // Our MockWebServer. We use a response delay to simulate real-world conditions
-    private val server = ImageMockWebServer(responseDelayMs = 200)
+    private val server = ImageMockWebServer()
 
     @Before
     fun setup() {