Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle properly player controls click #9862

Closed
wants to merge 1 commit into from
Closed

Handle properly player controls click #9862

wants to merge 1 commit into from

Conversation

ivk1800
Copy link

@ivk1800 ivk1800 commented Jan 13, 2022

This is a fix for issue #9861

@ivk1800
Do not handle click if finger is lifted outside view;
d409ec9 
Do not handle click if finger is drag inside the view;
@icbaker icbaker requested a review from ojw28 January 14, 2022 10:06
@ojw28
Copy link
Contributor

ojw28 commented Mar 7, 2022

Thanks for the contribution! That said, I think overriding of onTouchEvent is more generally problematic (it's also responsible for #9605 and #8627), so I plan to fix the problem in a different way. Please follow along on #9861 for updates. Thanks!

@ojw28 ojw28 closed this Mar 7, 2022
@google google locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ojw28 ojw28 Awaiting requested review from ojw28

Assignees

@ojw28 ojw28

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivk1800 @ojw28