Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update all deps #276

Merged
merged 1 commit into from May 25, 2022
Merged

chore: update all deps #276

merged 1 commit into from May 25, 2022

Conversation

sethvargo
Copy link
Member

@sethvargo sethvargo commented May 24, 2022 •
edited

Closes #275

@sethvargo sethvargo requested a review from a team as a code owner May 24, 2022 18:59
@sethvargo sethvargo enabled auto-merge (squash) May 24, 2022 19:00
@sethvargo sethvargo requested a review from bharathkkb May 24, 2022 19:00
@sethvargo
Copy link
Member Author

Weird - looks like a typescript bug?

@verbanicm
Copy link
Member

Looks like it might be some other package that is out of date

@verbanicm
Copy link
Member

run npm update and it should work

@sethvargo
Copy link
Member Author

I did - I even deleted node_modules, and it's still failing with the same error locally.

@sethvargo sethvargo force-pushed the sethvargo/deps branch 3 times, most recently from 0d6e64e to 507a767 Compare May 25, 2022 15:05
verbanicm
verbanicm reviewed May 25, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@sethvargo sethvargo merged commit 5afe46f into main May 25, 2022
@sethvargo sethvargo deleted the sethvargo/deps branch May 25, 2022 16:11
@google-github-actions-bot google-github-actions-bot mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verbanicm verbanicm verbanicm approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch averikitsch is a code owner automatically assigned from google-github-actions/maintainers

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sethvargo @verbanicm