Skip to content

Commit

Permalink
Security considerations: ids are strings, not integers (#400)
Browse files Browse the repository at this point in the history
Fix doc regarding using assertion on IDs rather than names. They refer
to IDs as integers, where those are actually strings, so we need to
quote them.

I lost too many hours on this to let anyone else experience the same
issue :D

Signed-off-by: Joachim Jablon <ewjoachim@gmail.com>
  • Loading branch information
ewjoachim committed Mar 12, 2024
1 parent 55bd3a7 commit 33e827c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/SECURITY_CONSIDERATIONS.md
Expand Up @@ -40,7 +40,7 @@ curl -sfL -H "Accept: application/json" "https://api.github.com/repos/${REPO}" |
These can be used in an Attribute Condition:

```cel
assertion.repository_owner_id == 1342004 && assertion.repository_id == 260064828
assertion.repository_owner_id == '1342004' && assertion.repository_id == '260064828'
```

[cybersquatting]: https://en.wikipedia.org/wiki/Cybersquatting
Expand Down

0 comments on commit 33e827c

Please sign in to comment.