Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLideNUI: allow loading default settings from GLideN64.default.ini #2565

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

Rosalie241
Copy link
Contributor

This allows a ''distribution'' of Project64 with GLideN64 (i.e something my installer installs) to ship a file named GLideN64.default.ini which'll be used whenever a user clicks on Restore Defaults.

@Rosalie241
Copy link
Contributor Author

Build failure should be fixed when #2564 is merged.

@gonetz
Copy link
Owner

gonetz commented Sep 5, 2021

file named GLideN64.default.ini which'll be used whenever a user clicks on Restore Defaults.

Why it is necessary? What is wrong with config.resetToDefaults()?

@Rosalie241
Copy link
Contributor Author

file named GLideN64.default.ini which'll be used whenever a user clicks on Restore Defaults.

Why it is necessary? What is wrong with config.resetToDefaults()?

my installer installs Project64 with GLideN64, texture packs and a configuration file to make the entire setup automatic, some users accidentally click on Restore Defaults after experimenting with the settings themselves, causing the custom settings to be removed and texture pack(s) will be disabled then, which is annoying because then they ask me why the texture pack isn't loading, this PR makes it possible to let my installer ship a 'default' config file which is used whenever a user clicks on Restore Defaults, solving that issue for users and improving the user experience.

@gonetz
Copy link
Owner

gonetz commented Sep 7, 2021

Ok. As I see, the old behavior is preserved if GLideN64.default.ini is not present.

@gonetz gonetz merged commit 32312e0 into gonetz:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants