Scan Struct(issue_570) fixed #596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
requested changes
Feb 1, 2022
| func ensureLen(d reflect.Value, n int) { | ||
| if n > d.Cap() { | ||
| if(n!=nil && d!=nil) |
There was a problem hiding this comment.
Unfortunately This in invalid code, n is an int so can't be nil as such it doesn't compile as can be seen here:
https://go.dev/play/p/H4HgPUpzxPY
Comment on lines
+30
to
+52
| // I think this lines that I Add will help you to your bugs | ||
| type ipS struct { | ||
| Addr addr | ||
| } | ||
|
|
||
| type addr struct { | ||
| net.IP | ||
| } | ||
|
|
||
| func (t *addr) RedisScan(src interface{}) error { | ||
| if t == nil { | ||
| return errors.New("nil pointer") | ||
| } | ||
|
|
||
| switch src := src.(type) { | ||
| case string: | ||
| return t.UnmarshalText([]byte(src)) | ||
| case []byte: | ||
| return t.UnmarshalText(src) | ||
| default: | ||
| return fmt.Errorf("cannot convert from %T to %T", src, t) | ||
| } | ||
| } |
There was a problem hiding this comment.
This code is never used, so not sure why it's needed?
|
Thanks for the PR's @mohammadrezayousefpour but unfortunately they all have some serious issues making them invalid. Happy to discuss fixes on the relevant issues and for you to raise new PR's, but please refer to this PR as an example of how we would like to see that done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.