add Float64Map #564
Open
add Float64Map #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
requested changes
Jun 4, 2021
| @@ -449,6 +449,32 @@ func Int64Map(result interface{}, err error) (map[string]int64, error) { | |||
| return m, nil | |||
| } | |||
|
|
|||
| // Float64Map is a helper that converts an array of strings (alternating key, value) | |||
| // into a map[string]Float64Map. The HGETALL commands return replies in this format. | |||
There was a problem hiding this comment.
Suggested change
| // into a map[string]Float64Map. The HGETALL commands return replies in this format. | |
| // into a map[string]float64. The HGETALL commands return replies in this format. |
|
Any news on addressing the feedback? |
|
Checking to see if you could address the feedback @alphagot812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.