Adds descriptive error when failing to make concrete #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using lazy loading and the call to a resolver when making a concrete fails, that error wasn't wrapped and caused confusion since we didn't know which abstraction we were attempting to satisfy. Wrapping error so we know that: a) Error occurred during resolve call. b) What abstraction we were trying to resolve. This should make it easier to debug these failures in lazy loading situations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using lazy loading and the call to a resolver when making a concrete fails, that error wasn't wrapped and caused confusion since we didn't know which abstraction we were attempting to satisfy.
Wrapping error so we know that:
a) Error occurred during resolve call.
b) What abstraction we were trying to resolve.
This should make it easier to debug these failures in lazy loading situations.