Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pretty table crash by bumping version #2439

Merged
merged 4 commits into from Feb 1, 2023
Merged

Conversation

scx1332
Copy link
Collaborator

@scx1332 scx1332 commented Jan 30, 2023

No description provided.

@scx1332 scx1332 requested a review from a team January 30, 2023 14:31
@scx1332
Copy link
Collaborator Author

scx1332 commented Jan 30, 2023

If someone can, please check if golemsp is still working as intended (I don't know what kind of tables it should have)

@scx1332
Copy link
Collaborator Author

scx1332 commented Jan 30, 2023

Crate prettytable-rs contained unsafe code that was crashing.
phsym/prettytable-rs#146
It is fixed in 0.10 version so I've updated to that one.

@scx1332 scx1332 merged commit 678c540 into master Feb 1, 2023
@scx1332 scx1332 deleted the scx1332/fix_pretty_table branch February 1, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants