Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom headers parameter in init when using XHR to fetch audio #997

Merged
merged 1 commit into from Apr 3, 2020
Merged

Conversation

kalizi
Copy link

@kalizi kalizi commented Jul 16, 2018

Needed to add Authorization header for streaming file by using JWT, so just added headers parameter in howler init this way:

var howl = new Howl( {
    src: ['http://www.example.it/protected/f1.mp3', 'http://www.example.it/protected/f2.mp3'],
    format: ['mp3'],
    html5: false,
    headers: [
        {
            name: 'Authorization',
            value: 'Bearer ' + token
        }
    ]
});

@Slurp
Copy link

Slurp commented Oct 1, 2018

Hi,

Is there any idea when this does get merged?

@rowild
Copy link

rowild commented Oct 19, 2018

Would like to know, too, when this is going to be merged! Thanks!

@golayp
Copy link

golayp commented Mar 28, 2019

Is there a plan to include this feature yet ?

@RobAWarner
Copy link

Hi, I would also really appreciate this being merged.
I need to be able to provide an authorization header with the request.

@fgilio
Copy link

fgilio commented Jul 8, 2019

Any plans on merging this or a similar PR?

@v-margko
Copy link

Hi - joining the queue of those who is waiting for this PR check-in.
Do you have an estimate for that? I'd appreciate to use howler in our app but really need this functionality to work)

@golayp
Copy link

golayp commented Nov 13, 2019

Hi - joining the queue of those who is waiting for this PR check-in.
Do you have an estimate for that? I'd appreciate to use howler in our app but really need this functionality to work)
I don't think it'll be merged one day... I've forked and made necessary adapations on my own long ago...

@v-margko
Copy link

Hi - joining the queue of those who is waiting for this PR check-in.
Do you have an estimate for that? I'd appreciate to use howler in our app but really need this functionality to work)
I don't think it'll be merged one day... I've forked and made necessary adapations on my own long ago...

hi, sorry, but did you plan to write an answer to me? or really wanted just to quote my question?)

@fgilio
Copy link

fgilio commented Nov 14, 2019

Haha if you look really closely he also wrote this:

I don't think it'll be merged one day... I've forked and made necessary adapations on my own long ago...

@v-margko
Copy link

Haha if you look really closely he also wrote this:
Oh.. I see X) thank you!

@Androsid
Copy link

@goldfire check out this merge. we really need these changes!

@goldfire goldfire merged commit c9ca0be into goldfire:master Apr 3, 2020
goldfire added a commit that referenced this pull request Apr 3, 2020
@fgilio
Copy link

fgilio commented Apr 3, 2020

It's happening! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants