Added 'metadata' option to preload #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazywire
force-pushed
the
preload-property
branch
from
123fbdd
to
c9f3e5e
Compare
|
@goldfire |
|
@crazywire Can you update if there was any progress or intention to merge this? |
|
It doesn't work. when we use 'metadata' it downloads the entire audio. |
|
@goldfire this isn't working. Even after using preload as metadata. |
|
Can confirm, this does not work :( |
kadw108
added a commit
to kadw108/Messages-From-the-Universe-Graveyard
that referenced
this pull request
Apr 7, 2024
Was attempting to add howler's html5 preload feature, not sure if it works (see goldfire/howler.js#1140) Also changed last two .mp3 files to .ogg files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you want to load a playlist and show only the duration of each audio, the browser will download all the files in the background. This pull request makes it possible to load only the metadata by passing 'metadata' to preload option.
@goldfire could you please check this and merge.