New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deadline is now deprecated, but should be taking its value from the configuration if set #822

Merged

jirfag merged 5 commits into golangci:master from dcaba:deadlineInConfigFix

Oct 15, 2019

Commits on Oct 15, 2019

test that demostrates that deadline is not working if comes from the …
```
…config
```
dcaba committed Oct 15, 2019
Copy the full SHA

8eff169 View commit details

Browse the repository at this point in the history
overriding timeout with deadline when only deadline is different from…
```
… its default value
```
dcaba committed Oct 15, 2019
Copy the full SHA

8e36063 View commit details

Browse the repository at this point in the history
tests were not passing. default value for Deadline, that now only com…
```
…es from config, is 0. Plus static check is going to fail because of deprecated cfg used
```
dcaba committed Oct 15, 2019
Copy the full SHA

d624291 View commit details

Browse the repository at this point in the history
golangci should use the latest golangci-lint version, that is the one…
```
… deprecating deadline in favour of timeout
```
dcaba committed Oct 15, 2019
Copy the full SHA

78aac40 View commit details

Browse the repository at this point in the history
README updated - looks the ci config in this project is used to gener…
```
…ate usage instructions.. great!
```
dcaba committed Oct 15, 2019
Copy the full SHA

fdd81c9 View commit details

Browse the repository at this point in the history