Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix body close panic. #610

Merged
merged 1 commit into from
Jul 14, 2019
Merged

fix body close panic. #610

merged 1 commit into from
Jul 14, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 13, 2019

Related to timakin/bodyclose#14

Can be a fix for #608

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2019

CLA assistant check
All committers have signed the CLA.

@jirfag jirfag merged commit 7e170af into golangci:master Jul 14, 2019
@jirfag
Copy link
Member

jirfag commented Jul 14, 2019

thank you!

@ldez ldez deleted the fix/bodyclose branch July 20, 2019 22:14
@korya
Copy link

korya commented Jul 29, 2019

@jirfag Any chance you can make a patch release containing the fix?

@Helcaraxan Helcaraxan mentioned this pull request Aug 29, 2019
@jirfag
Copy link
Member

jirfag commented Sep 10, 2019

@korya sorry for the slow response.
I've publised v1.18.0 release

@korya
Copy link

korya commented Sep 10, 2019

Great! Thanks!

I really like what you are doing and I appreciate it a lot. However, I believe this project is a very important piece in the GO ecosystem today. After gometalinter was deprecated in favor of this project, it became the ultimate GO linter. This is a reason why I think it is bad for such a project to depend on a single person and be paralyzed when this person has no time to deal with it. This is why I think you need to consider adding more people who can merge PRs and make patch releases (this part probably can be automated).
Update: I have just noticed #669

Again, I really appreciate the work you are doing. Thanks a lot!

@ldez ldez added the linter: update version Update version of linter label Dec 7, 2020
@ldez ldez added this to the v1.18 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants